CP-49045: drop global lock around sexpression parsing

TODO: this will need lots of testing and review. Should probably start by reproducing the original issue with a unit test. Signed-off-by: Edwin Török <[email protected]>
edwintorok · Apr 29, 2024 · 18dea0e · 18dea0e
1 parent f442701
commit 18dea0e
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/ocaml/libs/sexpr/sExpr_TS.ml b/ocaml/libs/sexpr/sExpr_TS.ml
@@ -12,11 +12,6 @@
  * GNU Lesser General Public License for more details.
  *)
 
-let lock = Mutex.create ()
-
-let of_string s =
-  Xapi_stdext_threads.Threadext.Mutex.execute lock (fun () ->
-      SExprParser.expr SExprLexer.token (Lexing.from_string s)
-  )
+let of_string s = SExprParser.expr SExprLexer.token (Lexing.from_string s)
 
 let string_of = SExpr.string_of