Fix Ranks off-by-one error (#27)

eduherminio · Nov 17, 2021 · afc06c7 · afc06c7
1 parent 3d4c17a
commit afc06c7
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/LichessTournamentAggregator.App/LichessTournamentAggregator.App.csproj b/LichessTournamentAggregator.App/LichessTournamentAggregator.App.csproj
@@ -7,7 +7,7 @@
     <RuntimeIdentifiers>win-x64;win-x86;linux-x64;osx-x64</RuntimeIdentifiers>
     <PublishSingleFile>true</PublishSingleFile>
     <PublishTrimmed>true</PublishTrimmed>
-    <Version>0.3.1</Version>
+    <Version>0.3.2</Version>
     <Authors>Eduardo Cáceres</Authors>
     <Description>
       Multiplatform desktop app that allows you to aggregate the results of multiple Lichess tournaments

diff --git a/LichessTournamentAggregator.Test/AggregatedResultTest.cs b/LichessTournamentAggregator.Test/AggregatedResultTest.cs
@@ -184,7 +184,7 @@ public void Ranks()
 
             foreach (var rank in aggregatedResult.Ranks)
             {
-                Assert.Single(results, (result) => result.Username == aggregatedResult.Username && result.Rank + 1 == rank);
+                Assert.Single(results, (result) => result.Username == aggregatedResult.Username && result.Rank == rank);
             }
         }
 

diff --git a/LichessTournamentAggregator/LichessTournamentAggregator.csproj b/LichessTournamentAggregator/LichessTournamentAggregator.csproj
@@ -7,7 +7,7 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <Title>LichessTournamentAggregator</Title>
     <PackageId>LichessTournamentAggregator</PackageId>
-    <Version>0.4.1</Version>
+    <Version>0.4.2</Version>
     <PackageTags>Chess, Lichess, Tournament, Aggregator</PackageTags>
     <Tags>$(PackageTags)</Tags>
     <Authors>Eduardo Cáceres</Authors>

diff --git a/LichessTournamentAggregator/Model/AggregatedResult.cs b/LichessTournamentAggregator/Model/AggregatedResult.cs
@@ -56,7 +56,7 @@ public AggregatedResult(IGrouping<string, TournamentResult> results)
             Username = results.First().Username;
             Title = results.First().Title;
             MaxRating = results.Max(p => p.Rating);
-            Ranks = results.Select(p => p.Rank + 1);
+            Ranks = results.Select(p => p.Rank);
             Scores = results.Select(p => p.Score >= p.Points ? p.Score : p.Points);  // A TournamentResult should only have either Score (Arena tournaments) or Points (Swiss tournaments)
             TieBreaks = results.Select(p => p.TieBreak);
             TotalScores = Scores.Sum();