Skip to content

Commit

Permalink
fix: fixed width issue of incontext sidebar (openedx#1395)
Browse files Browse the repository at this point in the history
  • Loading branch information
sundasnoreen12 authored May 27, 2024
1 parent e3ecee1 commit 1264b42
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/courseware/course/new-sidebar/common/SidebarBase.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ SidebarBase.propTypes = {

SidebarBase.defaultProps = {
title: '',
width: '50rem',
width: '45rem',
allowFullHeight: false,
showTitleBar: true,
className: '',
Expand Down
4 changes: 2 additions & 2 deletions src/courseware/course/sidebar/common/SidebarBase.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const SidebarBase = ({
'd-none': currentSidebar !== sidebarId,
}, className)}
data-testid={`sidebar-${sidebarId}`}
style={{ minWidth: shouldDisplayFullScreen ? '100%' : width }}
style={{ width: shouldDisplayFullScreen ? '100%' : width }}
aria-label={ariaLabel}
id="course-sidebar"
>
Expand Down Expand Up @@ -98,7 +98,7 @@ SidebarBase.propTypes = {
};

SidebarBase.defaultProps = {
width: '410px',
width: '31rem',
showTitleBar: true,
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ const NotificationTray = ({ intl }) => {
title={intl.formatMessage(messages.notificationTitle)}
ariaLabel={intl.formatMessage(messages.notificationTray)}
sidebarId={ID}
width="45rem"
className={classNames({
'h-100': !verifiedMode && !shouldDisplayFullScreen,
'ml-4': !shouldDisplayFullScreen,
Expand Down

0 comments on commit 1264b42

Please sign in to comment.