Silicon/Rockchip: PWMLib: Insert delay after locking previous period …

…& duty Otherwise the new values would sometimes be ignored.
edk2-porting · Oct 7, 2023 · 105f7b9 · 105f7b9
1 parent 8b6b3a6
commit 105f7b9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/edk2-rockchip/Silicon/Rockchip/Library/PWMLib/PWMLib.c b/edk2-rockchip/Silicon/Rockchip/Library/PWMLib/PWMLib.c
@@ -9,6 +9,7 @@
 
 #include <Library/DebugLib.h>
 #include <Library/IoLib.h>
+#include <Library/TimerLib.h>
 #include <Library/PWMLib.h>
 
 #define PWM_INT_EN(ch)                      (1 << (ch))
@@ -81,6 +82,7 @@ RkPwmSetConfig (
   Ctrl = MmioRead32(Base + ChannelOffset + PWM_CTRL_OFFSET);
   Ctrl |= PWM_LOCK;
   MmioWrite32(Base + ChannelOffset + PWM_CTRL_OFFSET, Ctrl);
+  MicroSecondDelay (1);
 
   MmioWrite32(Base + ChannelOffset + PWM_PERIOD_HPR_OFFSET, PeriodCycle);
   MmioWrite32(Base + ChannelOffset + PWM_DUTY_LPR_OFFSET, DutyCycle);

diff --git a/edk2-rockchip/Silicon/Rockchip/Library/PWMLib/PWMLib.inf b/edk2-rockchip/Silicon/Rockchip/Library/PWMLib/PWMLib.inf
@@ -21,6 +21,7 @@
 [LibraryClasses]
   DebugLib
   IoLib
+  TimerLib
 
 [Packages]
   EmbeddedPkg/EmbeddedPkg.dec