Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Provider fixes & enhancements #40

Open
wants to merge 15 commits into
base: metadata-provider
Choose a base branch
from

Conversation

fcurdi
Copy link

@fcurdi fcurdi commented Mar 19, 2020

Fix and add some missing features that came up when reading some libraries dlls. This Pull Request several features and changes because they were dependant on each other.

  • Include Properties:
  • Include Generic Parameter Constraints:
  • Move FakeArrayType to Types since it is needed to know if a type is of this type. Also renamed it to ArrayTypeWrapper.
  • Move some utility MethodDefinition methods to Extensions so they can be used by references as well.
  • Add Version, Culture and PublicKey to IAssemblyReference.
  • Include a method reference to CreateArrayInstruction
    • Some arrays like multidimensional ones are created with the newobj instruction that needs a method reference to its constructor.
  • Include method reference to StoreArrayElementInstruction and LoadArrayElementInstruction
    • This instructions are method calls in the bytecode and also need a method reference.
  • Some fields like ContainingAssembly, ContainingNamespace and generic parameters were being set in the ExtractType/Method/etc() method and now they are set in the GetDefinedType/Method/etc() methods. This is because this info is sometimes needed before the ExtractType/Method/etc() is called (with references for example).
  • Add OverridenMethod to MethodDefinition.
    • This points to the method that is being overriden.
    • It is needed for method generation.
  • Add Custom attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants