Ignore updator in api/*/get for consistency (fix #156)

edemaine · Mar 16, 2021 · 8a34895 · 8a34895
1 parent 2e4d6b9
commit 8a34895
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/doc/api.md b/doc/api.md
@@ -58,6 +58,9 @@ Responses often include "presence" objects which consist of two fields:
 
 ## Query Operations
 
+For consistency with other API calls, query operations can specify an
+`updator` field, which is ignored.
+
 ### `/api/meeting/get`: Fetch data for one or more meetings
 
 Request fields: (either `meeting` or `meetings` is required)

diff --git a/server/api.coffee b/server/api.coffee
@@ -29,6 +29,7 @@ checker =
   room: checkRoom
   tab: checkTab
 apiGet = (type) -> (options) ->
+  delete options.updator  # for consistency across different API calls
   "#{type}s": Meteor.call "#{type}Get", options
 apiNew = (type) -> (options) ->
   ## /api/meeting/new cannot require secret, but other operations do
@@ -70,7 +71,9 @@ apiMethods =
   '/meeting/edit': apiEdit 'meeting'
   '/room/edit': apiEdit 'room'
   '/tab/edit': apiEdit 'tab'
-  '/log/get': (options) -> logs: Meteor.call 'logGet', options
+  '/log/get': (options) ->
+    delete options.updator  # for consistency across different API calls
+    logs: Meteor.call 'logGet', options
 
 ## Allow CORS for API calls
 WebApp.rawConnectHandlers.use '/api', (req, res, next) ->