Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ESM fully #124

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Migrate to ESM fully #124

merged 3 commits into from
Oct 17, 2023

Conversation

LostCrew
Copy link
Member

  • Turn on type: module in package.json
  • Adjust webpack config accordingly

axlwaii
axlwaii approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@axlwaii axlwaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work! Nice one 🎉

@LostCrew LostCrew merged commit e66374f into main Oct 17, 2023
2 checks passed
@LostCrew LostCrew deleted the esm branch October 17, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axlwaii axlwaii axlwaii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LostCrew @axlwaii