-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for theia.DebugSession.parentSession #55
base: master
Are you sure you want to change the base?
Add support for theia.DebugSession.parentSession #55
Conversation
Adds support for the parentSession property in theia.d.ts. Includes some minor changes to make sure we're not sending theia.DebugSession object over the wire, but only session ids. Contributed on behalf of ST Microelectronics Signed-off-by: Thomas Mäder <[email protected]>
@planger how about a review? |
@tsmaeder I cannot see a pre-built copy of the extension on this PR or the issue. Am i not seeing something? 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Apart from the missing pre built extension i mentioned above this looks and works great!
Promises, promises! Here you go: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you! I already tested it, as i still had the extension from my earlier review, but the theia main repo reviewer will probably not have it 😉
LGTM 👍
What it does
Add suppport vor DebugSession.parentSession. Fixes eclipse-theia#11512
Adds support for the parentSession property in theia.d.ts. Includes some minor changes to make sure we're not sending theia.DebugSession object over the wire, but only session ids.
Contributed on behalf of ST Microelectronics
How to test
Review checklist
Reminder for reviewers