-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: make type casts explicit #170
base: main
Are you sure you want to change the base?
Conversation
461c840
to
7d9126b
Compare
Thanks for working on this. The warnings usually are there for a reason, and shutting them up with type casts is not always the best solution. One example is the return type of |
Thank you for your feedback, @obgm! I will revisit the casts and try to come up with a cleaner solution :) |
7d9126b
to
50b2bcc
Compare
2290590
to
6f79c4f
Compare
Just a quick update: I now managed to get rid of most of the type casts while keeping stricter compiler settings (adding the |
As another follow-up to #126, when compiling with Visual Studio, there are a lot of warnings regarding a potential data loss due to implicit casts with a potential lossy conversion.
This PR makes the type casts in question explicit, getting rid of potential warnings.