dtls.c: use GET_VAR_FIELD in dtls_get_cookie.

Signed-off-by: Achim Kraus <[email protected]>
eclipse · Aug 28, 2024 · d843302 · d843302
1 parent 1f1bc2a
commit d843302
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/dtls.c b/dtls.c
@@ -437,6 +437,7 @@ dtls_write(struct dtls_context_t *ctx, session_t *session,
 
 static int
 dtls_get_cookie(uint8 *msg, size_t msglen, uint8 **cookie) {
+  size_t cookie_len;
   /* To access the cookie, we have to determine the session id's
    * length and skip the whole thing. */
   if (msglen < DTLS_HS_LENGTH + DTLS_CH_LENGTH + sizeof(uint8))
@@ -452,11 +453,11 @@ dtls_get_cookie(uint8 *msg, size_t msglen, uint8 **cookie) {
   SKIP_VAR_FIELD(msg, msglen, uint8, DTLS_ALERT_HANDSHAKE_FAILURE,
                  "get_cookie, session_id");
 
-  if (msglen < (*msg & 0xff) + sizeof(uint8))
-    return dtls_alert_fatal_create(DTLS_ALERT_HANDSHAKE_FAILURE);
+  GET_VAR_FIELD(cookie_len, msg, msglen, uint8, DTLS_ALERT_HANDSHAKE_FAILURE,
+                "get_cookie, cookie");
 
-  *cookie = msg + sizeof(uint8);
-  return dtls_uint8_to_int(msg);
+  *cookie = msg;
+  return cookie_len;
 }
 
 static int