Fix Open XL compiler warnings

Changes along with the diagnostic flags: compiler/optimizer/ValuePropagationCommon.cpp [-Wsometimes-uninitialized] include_core/unix/zos/edcwccwi.h [-Wtrigraphs] util/a2e/atoe.c [-Wwritable-strings] util/a2e/headers/stdio.h [-Wwritable-strings] Signed-off-by: Gaurav Chaudhari <[email protected]>
eclipse · Aug 2, 2024 · 5617a37 · 5617a37
1 parent 21d60a7
commit 5617a37
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/compiler/optimizer/ValuePropagationCommon.cpp b/compiler/optimizer/ValuePropagationCommon.cpp
@@ -3295,7 +3295,7 @@ void OMR::ValuePropagation::transformRealTimeArrayCopy(TR_RealTimeArrayCopy *rtA
    //create ifNodes
    TR::Node *spineShiftNode = TR::Node::create(vcallNode, TR::iconst, 0, (int32_t)fe()->getArraySpineShift(elementSize));
    TR::TreeTop *ifTree;
-   TR::Node *ifNode;
+   TR::Node *ifNode = nullptr;
    TR::Node *srcOff = NULL, *dstOff = NULL;
    TR::Node *len = NULL;
    TR::SymbolReference *child1Ref = NULL, *child2Ref = NULL;

diff --git a/include_core/unix/zos/edcwccwi.h b/include_core/unix/zos/edcwccwi.h
@@ -24,10 +24,10 @@
  * @ddr_namespace: default
  */
 
-                   ??=ifndef __edcwccwi                                         
-                   ??=ifdef __COMPILER_VER__                                    
-                     ??=pragma filetag("IBM-1047")                              
-                   ??=endif                                                     
+                   #ifndef __edcwccwi                                         
+                   #ifdef __COMPILER_VER__                                    
+                     #pragma filetag("IBM-1047")                              
+                   #endif                                                     
                    #define __edcwccwi 1                                         
                    #pragma nomargins nosequence                                 
                    #pragma checkout(suspend)                                    
@@ -279,7 +279,7 @@ struct __jumpinfo_vr_ext
 	U_128 __ji_ve_savearea[32];
 } __jumpinfo_vr_ext_t_;
 
-#if ((!defined(_LP64) && defined(__XPLINK__))   ||         \                    
+#if ((!defined(_LP64) && defined(__XPLINK__))   ||         \
      (defined(_LP64)  && (__EDC_TARGET >= __EDC_LE4107)))
 typedef                                                                         
 struct __jumpinfo                                                               
@@ -360,7 +360,7 @@ __set_stack_softlimit
 
 #endif /* __XPLINK__  */                                                        
 #else                                                                           
-  #define __set_stack_softlimit(a) \                                            
+  #define __set_stack_softlimit(a) \
     struct __no64bitSupport __set_stack_softlimit                               
 #endif /* ! _LP64 */                                                            
 
@@ -580,7 +580,7 @@ struct __event1_s {
 
   #endif                                                                        
   #else                                                                         
-    #define __stack_info(a,b) \                                                 
+    #define __stack_info(a,b) \
       struct __no64bitSupport __stack_info                                      
   #endif                                                                        
 
@@ -610,4 +610,4 @@ struct __event1_s {
 #endif                                                                          
 
                    #pragma checkout(resume)                                     
-                   ??=endif /* __edcwccwi */
+                   #endif /* __edcwccwi */
diff --git a/util/a2e/atoe.c b/util/a2e/atoe.c
@@ -1341,7 +1341,7 @@ std_sprintf(const char *buf, char *ascii_chars, ...)
  * returns     -
  *************************************************************************/
 int
-atoe_sprintf(char *buf, char *ascii_chars, ...)
+atoe_sprintf(char *buf, const char *ascii_chars, ...)
 {
 	int len;
 	char wrkbuf[BUFLEN];
@@ -1370,7 +1370,7 @@ atoe_sprintf(char *buf, char *ascii_chars, ...)
  * returns     -
  *************************************************************************/
 int
-atoe_snprintf(char *buf, size_t buflen, char *ascii_chars, ...)
+atoe_snprintf(char *buf, size_t buflen, const char *ascii_chars, ...)
 {
 	int len;
 

diff --git a/util/a2e/headers/stdio.h b/util/a2e/headers/stdio.h
@@ -59,8 +59,8 @@
         int        atoe_printf    (const char*, ...);
         int        atoe_putchar   (int);
         int        atoe_rename    (const char*, const char*);
-        int        atoe_sprintf   (char*, char*, ...);
-        int        atoe_snprintf  (char *buf, size_t buflen, char *ascii_chars, ...);
+        int        atoe_sprintf   (char*, const char*, ...);
+        int        atoe_snprintf  (char *buf, size_t buflen, const char *ascii_chars, ...);
         int        std_sprintf    (const char*, char*, ...);
         int        atoe_sscanf    (const char*, const char*, ...); /*ibm@2609*/
         char *     atoe_tempnam   (const char *, char *);