Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ISSUE TEMPLATES #169

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Update ISSUE TEMPLATES #169

merged 1 commit into from
Jul 7, 2023

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Jul 6, 2023

Description

Update devenv-github-templates to v1.0.2

Issue ticket number and link

ADO#15591

Checklist

  • Vehicle App can be started with dapr run and is connecting to vehicle data broker

  • Vehicle App can process MQTT messages and call the seat service

  • Vehicle App can be deployed to local K3D and is running

  • Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.

  • Extended the documentation in Velocitas repo

  • Extended the documentation in README.md

  • Devcontainer can be opened successfully

  • Devcontainer can be opened successfully behind a corporate proxy

  • Devcontainer can be re-built successfully

  • Release workflow is passing

@kse3hi kse3hi requested a review from MP91 July 7, 2023 06:39
MP91
MP91 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@MP91 MP91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kse3hi kse3hi merged commit 98c639b into main Jul 7, 2023
@kse3hi kse3hi deleted the feature/update_issue_template branch July 7, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MP91 MP91 MP91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kse3hi @MP91