Implement cross compilation #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doosuu
reviewed
Mar 18, 2024
| @@ -47,7 +47,7 @@ else() | |||
| endif() | |||
|
|
|||
| add_subdirectory(app) | |||
|
|
|||
| set_target_properties(app PROPERTIES OUTPUT_NAME ${BIN_NAME}) | |||
There was a problem hiding this comment.
due the cross compilation, the build is basically running twice and to ensure that both binaries are kept, I added this to have different names for the different architectures
doosuu
requested changes
Mar 18, 2024
| FROM --platform=$TARGETPLATFORM bash:latest as mover | ||
| COPY --from=builder /workspace/build/bin/app_* / | ||
| COPY ./utils/delete.sh /delete.sh | ||
| CMD ["bash", "/delete.sh $TARGETPLATFROM"] |
There was a problem hiding this comment.
Suggested change
| CMD ["bash", "/delete.sh $TARGETPLATFROM"] | |
| CMD ["bash", "/delete.sh", $TARGETPLATFROM] |
|
|
||
| # search headers and libraries in the target environment | ||
| set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY) | ||
| set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY) |
There was a problem hiding this comment.
Missing empty newline at the end of the file
|
|
||
| RUN strip /workspace/build/bin/app | ||
| # Intermediate stage to delete unused executable | ||
| FROM --platform=$TARGETPLATFORM bash:latest as mover |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue ticket number and link
Checklist
Vehicle App can be started with dapr run and is connecting to vehicle data broker
Vehicle App can process MQTT messages and call the seat service
Vehicle App can be deployed to local K3D and is running
Created/updated tests, if necessary. Code Coverage percentage on new code shall be >= 70%.
Extended the documentation in Velocitas repo
Extended the documentation in README.md
Devcontainer can be opened successfully
Devcontainer can be opened successfully behind a corporate proxy
Devcontainer can be re-built successfully
Release workflow is passing