Update only generated Code during gRPC Code Re-generation #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "user-defined" area has been removed from the cpp header template. Instead all code is persisted between two "code re-generations" except of the "auto-generated" code. The "auto-generated" code is correctly updated depending on if services where added or removed between two consecutive "code re-generations".
Chrylo
suggested changes
Sep 6, 2024
|
Tested: |
|
Converted to draft until velocitas-lib PR is merged |
|
LGTM |
Chrylo
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "user-defined" area has been removed from the cpp header template. Instead all code is persisted between two "code re-generations" except of the "auto-generated" code. The "auto-generated" code is correctly updated depending on if services where added or removed between two consecutive "code re-generations".
The following branch can be used for testing:
https://github.com/SoftwareDefinedVehicle/vehicle-app-cpp-template-lattice/tree/update_autogenerated_code_only_test
Tested Scenarios:
given: the gRPC generated header does not exist
and: re-generate code is executed
then: the header is correctly generated using the default template
and: the generated code matches with the proto file
given: the gRPC generated header does exist
and: the existing generated header file has been changed by the user (e.g. a custom constructor is introduced)
and: a new method is added to the proto file
and: re-generate code is executed
then: the auto generated code is updated (e.g. the new method is added to the auto-generated code)
and: the rest of the header file is not changed
analogue for the use case, where a service is removedfrom the proto file definition