Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up scripts and re-use common functionality #77

Merged
merged 18 commits into from
Aug 14, 2024
Merged

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Jul 10, 2024

This PR splits up the onCreateCommand.sh used by various languages (c++, python) and replaces it with a generic one which calls out to language specific extension scripts.

@doosuu doosuu force-pushed the doosuu/script-cleanup branch 30 times, most recently from 60301ab to c60bf34 Compare July 11, 2024 09:07
setup/src/common/scripts/upgrade-cli.sh Outdated Show resolved Hide resolved
setup/src/common/scripts/onCreateCommand.sh Show resolved Hide resolved
setup/src/common/scripts/onCreateCommand.sh Show resolved Hide resolved
setup/src/cpp/common/scripts/setup-dependencies.sh Outdated Show resolved Hide resolved
setup/src/python/sdk/scripts/setup-dependencies.sh Outdated Show resolved Hide resolved
setup/src/python/app/scripts/setup-dependencies.sh Outdated Show resolved Hide resolved
setup/src/common/scripts/setup-git.sh Outdated Show resolved Hide resolved
setup/src/common/scripts/configure-codespaces.sh Outdated Show resolved Hide resolved
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doosuu doosuu merged commit 7798115 into main Aug 14, 2024
17 checks passed
@doosuu doosuu deleted the doosuu/script-cleanup branch August 14, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants