Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default VSS #39

Merged
merged 3 commits into from
Oct 13, 2023
Merged

fix: Add default VSS #39

merged 3 commits into from
Oct 13, 2023

Conversation

doosuu
Copy link
Member

@doosuu doosuu commented Oct 13, 2023

In case there is no VSS explicitly given by the AppManifest, a fallback is provided. This is needed because we do not have a dependency resolver yet and KUKSA DataBroker needs a vss path to be mounted.

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Coverage: sdk-installer

File Coverage Lines Branches
All files 25% 41% 9%
sdk-installer/src/run.py 19% 29% 9%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 6be4671

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Coverage: grpc-interface-support

File Coverage Lines Branches
All files 51% 62% 40%
grpc-interface-support/src/conan_helper.py 64% 60% 68%
grpc-interface-support/src/util/__init__.py 23% 23% 0%
grpc-interface-support/src/util/templates.py 28% 28% 0%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 6be4671

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Coverage: setup

File Coverage Lines Branches
All files 100% 100% 100%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 6be4671

@github-actions
Copy link

Coverage: vehicle-model-lifecycle

File Coverage Lines Branches
All files 87% 90% 84%
vehicle-model-lifecycle/src/download_vspec.py 96% 98% 95%
vehicle-model-lifecycle/src/generate_model.py 54% 59% 50%

Minimum allowed coverage is 80%

Generated by 🐒 cobertura-action against 6be4671

Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@doosuu doosuu merged commit 055d3e1 into main Oct 13, 2023
18 checks passed
@doosuu doosuu deleted the fix/default-vss branch October 13, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants