buffer file outputs #4388
Merged
buffer file outputs #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes "Resolving MavenDependencyRoots..." output somewhat faster on my machine.
Test Results 603 files 603 suites 4h 21m 3s ⏱️ For more details on these failures, see this check. Results for commit e3873fa. |
laeubi
approved these changes
Oct 26, 2024
laeubi
added
the
backport-to-tycho-4.0.x
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes "Resolving MavenDependencyRoots..." output somewhat faster on my machine. I started from org.eclipse.tycho.core.resolver.MavenTargetDefinitionContent.generateSourceBundle(String, String, Manifest, File, IArtifactFacade), which took notable time in the profiler, and I then added buffered outputstreams and buffered writers to all FileOutputStreams.
I've run a local build of another project with this snapshot, but I have not run Tycho tests (my company machine fails too much with proxy stuff there and I can't get to my private machine for some days).