-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for build with updated bundle versions #3899
base: main
Are you sure you want to change the base?
Conversation
Verifier verifier = runDemo("pde-automatic-manifest"); | ||
|
||
// now update the version | ||
Verifier updateVerifier = super.getVerifier("../../demo/pde-automatic-manifest", true, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need a new verifier here just reuse the one from above.
As you should get a copy for the test i don't think this is required? |
@fipro78 for some reason this now has compile errors :-\ |
It somehow has changed the import statement. Can't explain why, but that seems to be the reason. |
@fipro78 now all test succeed... can you maybe give some manual instructions and where /when you would it expect to fail with the given example? I'll then take a look at it. |
I followed my tutorial after I updated to the automatic manifest generation. And everytime I change the version back and forth the issue appears. https://github.com/fipro78/e4-cookbook-basic-recipe/blob/master/tutorials/Eclipse_RCP_Cookbook_p2.md |
This adds a test that