Improve caching of artifacts using new Transport#downloadArtifact #3771
+61
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Tycho maintain different caches, e.g. some items are cached in the local maven repository, some are cached in the transport caches and there is even a P2 remote cache maintained. Apart from that, P2/PDE/Ooomph also maintain so called bundle pools. With the new Transport#downloadArtifact method we now have an opportunity to merge all these caches in a reliable way just using the artifact that is already there saving both downloads times and disk space.
Test Results 594 files 594 suites 3h 48m 37s ⏱️ Results for commit ef64935. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Tycho maintain different caches, e.g. some items are cached in the local maven repository, some are cached in the transport caches and there is even a P2 remote cache maintained. Apart from that, P2/PDE/Ooomph also maintain so called bundle pools.
With the new Transport#downloadArtifact method we now have an opportunity to merge all these caches in a reliable way just using the artifact that is already there saving both downloads times and disk space.