Add build timestamp to the manifest and enable deep aggregate inspection #3364
+464
−354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the build timestamp is only encoded in the file-name. This is then parsed back from the string into a date. This has several drawbacks: - it is sometimes unreliable and usually the user won't notice that e.g. when the dependency and the build are using different formating rules for qualifiers - it does not work well for "standard" artifacts not build by Tycho that are probably not using qualifiers in the name Because of this, the following changes are applied: - the build timestamp is read from the reactor if possible - the build timestamp is written to the manifest as part of the packaging - if parsing is not successful the manifest is inspected if it contains some well known build time stamps from either Tycho or BND - if thats not available the jar entry time is used as a last resort both things can be configured but are enabled by default just in case it causes issues for the users and they rely on the old behavior.
laeubi
added
the
backport-to-tycho-4.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build timestamp is only encoded in the file-name. This is then parsed back from the string into a date.
This has several drawbacks:
Because of this, the following changes are applied:
both things can be configured but are enabled by default just in case it causes issues for the users and they rely on the old behavior.