Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tycho-surefire integration test for JUnit 5 suites #3342

Closed
wants to merge 1 commit into from

Conversation

HeikoKlare
Copy link
Contributor

@HeikoKlare HeikoKlare commented Jan 10, 2024

This is an initial draft for an integration test for using JUnit 5 suites in tycho-surefire.
It is supposed to demonstrate the behavior discussed in

@laeubi
Copy link
Member

laeubi commented Jan 10, 2024

@HeikoKlare the referenced issue seems odd, do you maybe want to reference another issue or an issue in a different repository?

@HeikoKlare
Copy link
Contributor Author

the referenced issue seems odd, do you maybe want to reference another issue or an issue in a different repository?

Thanks! Yes, sorry for that. I corrected the referenced issue.

@HeikoKlare
Copy link
Contributor Author

To ease investigation of the issue, here is the same test setup with pure Maven surefire: bundle.test.zip
That configuration works fine with test suite as long junit-platform-suite-engine is on the classpath.

@laeubi
Copy link
Member

laeubi commented Jan 14, 2024

@HeikoKlare

is this supposed to fix the mentioned issue:

@HeikoKlare
Copy link
Contributor Author

The test case provided here was only supposed to demonstrate the issue documented in:

The test case is also integrated into and thus subsumed by the PR supposed to fix the issue:

So in case #3358 gets merged, this becomes obsolete.

@HeikoKlare HeikoKlare deleted the issue-1454 branch January 19, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants