Sort input sources by name

eclipse-tycho · Jan 29, 2024 · 2252236 · 2252236
1 parent 7d01e91
commit 2252236
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/tycho-compiler-jdt/src/main/java/org/eclipse/tycho/compiler/jdt/JDTCompiler.java b/tycho-compiler-jdt/src/main/java/org/eclipse/tycho/compiler/jdt/JDTCompiler.java
@@ -110,6 +110,9 @@ public CompilerResult performCompile(CompilerConfiguration config) throws Compil
         if (sourceFiles.length == 0) {
             return new CompilerResult();
         }
+        //even though order of java sources should not matter, it can make a difference sometimes (e.g. lamda numbering) see https://github.com/eclipse-jdt/eclipse.jdt.core/issues/1921
+        //so to have always the same arguments regardless of hash table ordering that is used internally by plexus compiler we sort the files simply by name
+        Arrays.sort(sourceFiles);
 
         logger.info("Compiling " + sourceFiles.length + " " + "source file" + (sourceFiles.length == 1 ? "" : "s")
                 + " to " + destinationDir.getAbsolutePath() + " using " + COMPILER_NAME + "");