Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: PR template mentioned BAMM and SAMM #284

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix: PR template mentioned BAMM and SAMM #284

merged 1 commit into from
Sep 19, 2023

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

Description

The template had to small faulty information

  • mentioned BAMM instead of SAMM
  • validation command was outdated

Following criteria was updated:
(MS2 Criteria)

  • the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The SAMM CLI is available here and in GitHub
  • units are referenced from the BAMM unit catalog whenever possible

bs-jokri
bs-jokri approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bs-jokri bs-jokri merged commit 1cc72d3 into eclipse-tractusx:main Sep 19, 2023
4 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/templates branch January 29, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bs-jokri bs-jokri bs-jokri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-rm-meyer-ISST @bs-jokri