-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first version of UnsubscribeShopfloorInformation #237
first version of UnsubscribeShopfloorInformation #237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check comments
########################################################################################## | ||
# Copyright (c) 2023 Fraunhofer-Gesellschaft zur Förderung der angewandten Forschung e. V. | ||
# Copyright (c) 2023 Siemens AG | ||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (c) 2023 Contributors to the Eclipse Foundation
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> . | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> . | ||
@prefix : <urn:samm:io.catenax.mp_standard_unsubscribe:1.0.0#> . | ||
@prefix ext-header: <urn:samm:io.catenax.messaging_header:1.0.0#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which model is that? Where do I get it from?
if renaming of messaging_header model is required do not forget to adjust here
@prefix ext-header: <urn:samm:io.catenax.messaging_header:1.0.0#> . | ||
|
||
:UnsubscribeShopfloorInformation a samm:Aspect ; | ||
samm:preferredName "UnsubscribeShopfloorInformation"@en ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use normal orthography and proper noun. For whole model. Will not comment any further occasions
|
||
All notable changes to this model will be documented in this file. | ||
|
||
## [1.0.0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add date of MS3 approval as soon as it is available
Validation Report for io.catenax.mp_standard_unsubscribe/1.0.0/UnsubscribeShopfloorInformation.ttlValidation failed: |
@wehrstedt-jan I understood that this model is not required anymore. If so, could you please close the PR then. |
not required anymore |
Description
-->
Closes #232
requires use of header #227
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)