Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Model] ESS Supplier Response 1.0.0 #127

Closed
wants to merge 1 commit into from
Closed

[New Model] ESS Supplier Response 1.0.0 #127

wants to merge 1 commit into from

Conversation

sschul33
Copy link

@sschul33 sschul33 commented Mar 28, 2023 •
edited by bs-jokri
Loading

Description

-->

Closes #58

MS2 Criteria

(to be filled out by PR reviewer)

  • the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The BAMM CLI is available here and in GitHub
  • use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
  • the identifiers for all model elements start with a capital letter except for properties
  • the identifier for properties starts with a small letter
  • all model elements at least contain the fields "name" and "description" in English language.
  • no duplicate names or preferredNames within an Aspect (e.g. a Property and the referenced Characteristic should not have the same name)
  • the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
  • use abbreviations only when necessary and if these are sufficiently common
  • avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
  • fields preferredName and description are not the same
  • preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
  • name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
  • units are referenced from the BAMM unit catalog whenever possible
  • use constraints to make known constraints from the use case explicit in the aspect model
  • when relying on external standards, they are referenced through a "see" element
  • all properties with an simple type have an example value
  • metadata.json exists with status "release"
  • file RELEASE_NOTES.md exists and contains entries for proposed model changes

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

  • All required reviewers have approved this PR (see reviewers section)
  • The new aspect (version) will be implemented by at least one data provider
  • The new aspect (version) will be consumed by at least one data consumer
  • There exists valid test data
  • In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
  • The model has at least version '1.0.0'

@sschul33
Copy link
Author

@bs-jokri : Please review
@jacewski-bosch , @BenediktMuellerIML : FYI

@sschul33
Copy link
Author

sschul33 commented Apr 3, 2023

Modeling_Team

bs-jokri
bs-jokri suggested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add missing model elements and fix pref name and description as mentioned

io.catenax.ess_supplier_response/1.0.0/EssSupplierResponse.ttl
bamm:description "The payload of the ESS Supplier Response notification"@en;
bamm:characteristic :EssSupplierResponseContentCharacteristic.
:supplyChainImpacted a bamm:Property;
bamm:description "result of the supply chain analysis, i.e. if the inquiring company is impacted by the given incident.\nyes: the inquiring company is impacted by the incident because the given BPN is a direct or indirect supplier of the recipient of the ESS supplier request (i.e. the given BPN was found in the supply chain)\nno: the the inquiring company is not impacted by the incident because the given BPN is not a direct or indirect supplier of the recipient of the ESS supplier request (i.e. the given BPN was not found in the supply chain)\nunknown: no result"@en;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start uppercase

io.catenax.ess_supplier_response/1.0.0/EssSupplierResponse.ttl
:supplyChainImpacted a bamm:Property;
bamm:description "result of the supply chain analysis, i.e. if the inquiring company is impacted by the given incident.\nyes: the inquiring company is impacted by the incident because the given BPN is a direct or indirect supplier of the recipient of the ESS supplier request (i.e. the given BPN was found in the supply chain)\nno: the the inquiring company is not impacted by the incident because the given BPN is not a direct or indirect supplier of the recipient of the ESS supplier request (i.e. the given BPN was not found in the supply chain)\nunknown: no result"@en;
bamm:characteristic :SupplyChainImpactedCharacteristic.
:SupplyChainImpactedCharacteristic a bamm-c:Enumeration;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefered name missing
description missing

io.catenax.ess_supplier_response/1.0.0/EssSupplierResponse.ttl
bamm:preferredName "Content"@en;
bamm:description "The payload of the ESS Supplier Response notification"@en;
bamm:characteristic :EssSupplierResponseContentCharacteristic.
:supplyChainImpacted a bamm:Property;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferred name missing

io.catenax.ess_supplier_response/1.0.0/EssSupplierResponse.ttl
:SupplyChainImpactedCharacteristic a bamm-c:Enumeration;
bamm:dataType xsd:string;
bamm-c:values ("yes" "no" "unknown").
:EssSupplierResponseContentCharacteristic a bamm:Characteristic;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description missing
check pref name writing (also all other pref names)

io.catenax.ess_supplier_response/1.0.0/EssSupplierResponse.ttl
bamm:dataType :EssSupplierResponseContentEntity.
:EssSupplierResponseContentEntity a bamm:Entity;
bamm:properties (:supplyChainImpacted);
bamm:preferredName "EssSupplierResponseContentEntity"@en.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description missing, write prefered name in standard English

@bs-jokri
Copy link
Contributor

the new model for the header changes the approach, which is why we can close
#227

@bs-jokri bs-jokri closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bs-jokri bs-jokri bs-jokri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Model]: (Traceability) ESS Supplier Response
2 participants
@sschul33 @bs-jokri