Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): change to keycloak v22.0.3 #20

Merged
merged 29 commits into from
Oct 5, 2023

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented Sep 5, 2023

Description

  • change to v22.0.3 (bitnami chart version: 16.1.6)
  • chart changes:
    • bump chart version to to major 2.0.0 (alpha)
    • change appVersion from 1.2.0 to 22.0.3 to align with Keycloak version as that's more intuitive
    • add production mode with default false
    • change production mode to true for consortia envs
    • add reverse proxy mode with default 'passthrough'
    • change to proxy=edge (https://www.keycloak.org/server/reverseproxy) for consortia envs
    • remove service type: default value is ClusterIP in new bitnami chart version
    • remove proxyAddressForwarding
    • remove serviceDiscovery
    • set httpRelativePath to '/auth/', as we're migrating from 16.1.1 version which was using the trailing 'auth'
    • update retrieval of service name for seeding job
    • remove management-password from secrets as key isn't part of default secret anymore
    • fix escaping of secret values (add quotes)
  • add demo environment
  • update k8s version and version to upgrade from for helm test workflows

Why

change from Keycloak v16.1.1 to v22.0.3.

Issue

eclipse-tractusx/portal#84

Checklist

  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas
  • I have added a copyright and license header in all affected files

bitnami chart version: 16.1.0
as long as seeding job hasn't been changed to new kc version
default value is ClusterIP in new chart version
- remove proxyAddressForwarding and serviceDiscovery
- add production and reverse proxy mode
as we're migrating from 16.1.1 version which was using the trailing 'auth', we're setting it to '/auth/'.
@evegufy evegufy force-pushed the feat/keycloak-version-upgrade branch from 9f9201e to 2be004f Compare September 26, 2023 16:32
@evegufy evegufy changed the title chore: implement version upgrade chore(upgrade): change to keycloak v22.0.3 Sep 26, 2023
@evegufy evegufy changed the title chore(upgrade): change to keycloak v22.0.3 feat(upgrade): change to keycloak v22.0.3 Sep 26, 2023
@evegufy evegufy marked this pull request as ready for review September 26, 2023 20:06
@evegufy evegufy requested a review from Phil91 September 27, 2023 06:40
Phil91
Phil91 previously approved these changes Sep 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@evegufy evegufy merged commit c216d98 into main Oct 5, 2023
6 checks passed
@evegufy evegufy deleted the feat/keycloak-version-upgrade branch October 5, 2023 19:00
rmarting pushed a commit to rmarting/portal-iam that referenced this pull request Oct 12, 2023
change to v22.0.3 (Bitnami chart version: 16.1.6)
chart changes:
- bump chart version to to major 2.0.0 (alpha)
- change appVersion from 1.2.0 to 22.0.3 to align with Keycloak version as that's more intuitive
- add production mode with default false
- change production mode to true for consortia envs
- add reverse proxy mode with default 'passthrough'
- change to proxy=edge (https://www.keycloak.org/server/reverseproxy) for consortia envs
- remove service type: default value is ClusterIP in new Bitnami chart version
- remove proxyAddressForwarding
- remove serviceDiscovery
- set httpRelativePath to '/auth/', as we're migrating from 16.1.1 version which was using the trailing 'auth'
- update retrieval of service name for seeding job
- remove management-password from secrets as key isn't part of default secret anymore
- fix escaping of secret values (add quotes)
add demo environment
update k8s version and version to upgrade from for helm test workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants