feat: REGEX to allow long company names in BP invite #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Phil91 Tests still need to be adjusted. |
Phil91
previously approved these changes
Aug 16, 2024
This character in company names breaks keycloak.
This reverts commit 75ce0c7.
|
oyo
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
Business partner invite company name field was capped at 40 characters blocking the invite of companies with longer business names. REGEX from company name field in registration process has been used to maintain consistency. Backend implementation is also live and ready to accept company name lengths of 160 characters: eclipse-tractusx/portal-backend#860
Issue
eclipse-tractusx/portal#360
Checklist