feat(admin): validating bpn before adding to companyUser #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/administration/Administration.Service/BusinessLogic/UserBusinessLogic.cs
Fixed
Show fixed
Hide fixed
tests/administration/Administration.Service.Tests/BusinessLogic/UserBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
tests/administration/Administration.Service.Tests/BusinessLogic/UserBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
tests/administration/Administration.Service.Tests/BusinessLogic/UserBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
tests/administration/Administration.Service.Tests/BusinessLogic/UserBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
Phil91
force-pushed
the
feature/CPLP-3639-bpnCheck
branch
2 times, most recently
from
d0ea516
to
7b79f70
Compare
ntruchsess
force-pushed
the
feature/CPLP-3639-bpnCheck
branch
2 times, most recently
from
4105609
to
32399ec
Compare
ntruchsess
requested changes
Aug 13, 2024
| { | ||
| private readonly HttpClient _httpClient; | ||
| private readonly HttpClient _httpClient = httpFactory.CreateClient(nameof(BpnAccess)); |
There was a problem hiding this comment.
I'm not sure whether storing a reference to a factory-generated http-client in a member is advisable. According to https://learn.microsoft.com/en-us/dotnet/fundamentals/networking/http/httpclient-guidelines (section recommendet use httpclient-instances that were created by IHttpClientFactory should be short-lived objects. As http-client also implements IDisposable creating a new instance within FetchLegalEntityByBpn using the 'using'-keyword to dispose when it goes out of scope should be the correct way.
Ref : CPLP-3639
Refs: CPLP-3639
Phil91
force-pushed
the
feature/CPLP-3639-bpnCheck
branch
from
d2f22af
to
b0dfe53
Compare
Phil91
force-pushed
the
feature/CPLP-3639-bpnCheck
branch
from
b0dfe53
to
9a3561a
Compare
|
fixed |
ntruchsess
previously approved these changes
Sep 10, 2024
evegufy
requested changes
Sep 11, 2024
4 tasks
|
evegufy
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
validating bpn before adding to companyUser
Why
Added validation for BPN before adding to it companyUser
Issue
Refs : #901
Corresponding Portal PR
eclipse-tractusx/portal#426
Checklist