fix(OSP Invite): Handle theme for shared realm #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evegufy
previously requested changes
Jul 29, 2024
Phil91
requested changes
Jul 31, 2024
src/portalbackend/PortalBackend.DBAccess/Models/IdentityProvider.cs
Outdated
Show resolved
Hide resolved
src/registration/ApplicationActivation.Library/ApplicationActivationService.cs
Outdated
Show resolved
Hide resolved
dhiren-singh-007
force-pushed
the
bugfix/848-osp-invite-shared-theme
branch
from
31c98e5
to
d6a0bdb
Compare
dhiren-singh-007
requested review from
Phil91
and removed request for
Phil91 and
evegufy
|
@Phil91 @ntruchsess @MaximilianHauer This is also a breaking issue for OSP. Only keycloak as idp worked for us. We tested with Azure Entra and it tries to set theme, which it is not able to do. Was this setting the theme of the OSP keycloak client before? Might also not be a good idea to overwrite OSP themes. |
Phil91
approved these changes
Aug 5, 2024
dhiren-singh-007
requested review from
Phil91 and
evegufy
and removed request for
evegufy
|
Hi @dhiren-singh-007 thank you for the contribution! |
Phil91
previously approved these changes
Aug 6, 2024
dhiren-singh-007
force-pushed
the
bugfix/848-osp-invite-shared-theme
branch
from
8dd2105
to
22cf7bf
Compare
Phil91
requested changes
Aug 8, 2024
src/registration/ApplicationActivation.Library/ApplicationActivationService.cs
Outdated
Show resolved
Hide resolved
Phil91
approved these changes
Aug 8, 2024
evegufy
dismissed
their stale review
dismiss due to Phil and Norbert reviewing
ntruchsess
requested changes
Aug 13, 2024
src/registration/ApplicationActivation.Library/ApplicationActivationService.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/ApplicationRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/ApplicationRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/ApplicationRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Models/IdentityProvider.cs
Outdated
Show resolved
Hide resolved
src/registration/ApplicationActivation.Library/ApplicationActivationService.cs
Outdated
Show resolved
Hide resolved
src/registration/ApplicationActivation.Library/ApplicationActivationService.cs
Outdated
Show resolved
Hide resolved
dhiren-singh-007
force-pushed
the
bugfix/848-osp-invite-shared-theme
branch
from
65a6b62
to
078d548
Compare
|
Thanks @ntruchsess for the suggestion and giving more insights . I reverted all the commits and implemented the suggestion . Please re-review . |
|
ntruchsess
approved these changes
Aug 14, 2024
evegufy
force-pushed
the
release/v2.2.0-RC2
branch
from
801050d
to
6ca675f
Compare
evegufy
approved these changes
Aug 14, 2024
Phil91
approved these changes
Aug 14, 2024
evegufy
merged commit be8f1d7
into
eclipse-tractusx:release/v2.2.0-RC2
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified the
GetCompanyAndApplicationDetailsForApprovalAsyncmethod to get only shared idp aliasfix #848 close #848
Why
Earlier if we use Managed idp(eg using Azure AD) then application activation was failing because code was trying to set theme on shared realm, which don't exist.
Issue
Issue 848
Checklist
Please delete options that are not relevant.