Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(registration): add registrationType to response #481

Merged
merged 1 commit into from
Feb 3, 2024
Merged

feat(registration): add registrationType to response #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/portalbackend/PortalBackend.DBAccess/Models/CompanyApplicationWithStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ public record CompanyApplicationWithStatus
(
Guid ApplicationId,
CompanyApplicationStatusId ApplicationStatus,
CompanyApplicationTypeId ApplicationType,
IEnumerable<ApplicationChecklistData> ApplicationChecklist
);

public record ApplicationChecklistData(ApplicationChecklistEntryTypeId TypeId, ApplicationChecklistEntryStatusId StatusId);

public record CompanyApplicationDeclineData(
Expand Down
1 change: 1 addition & 0 deletions src/portalbackend/PortalBackend.DBAccess/Repositories/UserRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public IAsyncEnumerable<CompanyApplicationWithStatus> GetApplicationsWithStatusU
.Select(companyApplication => new CompanyApplicationWithStatus(
companyApplication.Id,
companyApplication.ApplicationStatusId,
companyApplication.CompanyApplicationTypeId,
companyApplication.ApplicationChecklistEntries.Select(ace =>
new ApplicationChecklistData(ace.ApplicationChecklistEntryTypeId, ace.ApplicationChecklistEntryStatusId))))
.AsAsyncEnumerable();
Expand Down
3 changes: 2 additions & 1 deletion tests/portalbackend/PortalBackend.DBAccess.Tests/UserRepositoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,8 @@ public async Task GetApplicationsWithStatusUntrackedAsync_ReturnsExpected()
// Assert
result.Should().NotBeNull().And.Satisfy(x =>
x.ApplicationId == new Guid("6b2d1263-c073-4a48-bfaf-704dc154ca9e") &&
x.ApplicationStatus == CompanyApplicationStatusId.SUBMITTED);
x.ApplicationStatus == CompanyApplicationStatusId.SUBMITTED &&
x.ApplicationType == CompanyApplicationTypeId.INTERNAL);
result.Single().ApplicationChecklist.Should().Satisfy(
y => y.TypeId == ApplicationChecklistEntryTypeId.APPLICATION_ACTIVATION && y.StatusId == ApplicationChecklistEntryStatusId.TO_DO,
y => y.TypeId == ApplicationChecklistEntryTypeId.BUSINESS_PARTNER_NUMBER && y.StatusId == ApplicationChecklistEntryStatusId.DONE,
Expand Down
1 change: 1 addition & 0 deletions tests/registration/Registration.Service.Tests/BusinessLogic/RegistrationBusinessLogicTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ public async Task GetAllApplicationsForUserWithStatus_WithValidUser_GetsAllRoles
new CompanyApplicationWithStatus(
_fixture.Create<Guid>(),
CompanyApplicationStatusId.VERIFY,
CompanyApplicationTypeId.INTERNAL,
new[]
{
new ApplicationChecklistData(ApplicationChecklistEntryTypeId.APPLICATION_ACTIVATION,
Expand Down
Loading