Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuget): create nuget packages for framework #325

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 3, 2023

Description

All framework projects are now available as nuget packages

Why

To be able to use the backend framework code in the policy hub

Issue

N/A - Jira Issue CPLP-3400

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from bf2a033 to 63db7dd Compare November 3, 2023 10:10
@Phil91 Phil91 marked this pull request as ready for review November 3, 2023 14:59
@Phil91 Phil91 marked this pull request as draft November 3, 2023 14:59
@Phil91 Phil91 marked this pull request as ready for review November 14, 2023 07:28
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from 2594078 to e38f263 Compare November 14, 2023 11:01
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch 2 times, most recently from 12070b9 to caef3a4 Compare January 13, 2024 12:44
@jjeroch jjeroch added this to the CX Release 24.03 milestone Jan 23, 2024
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from a7b503c to 2cb2e80 Compare January 23, 2024 13:10
@Phil91
Copy link
Member Author

Phil91 commented Jan 23, 2024

@ntruchsess , @evegufy please be aware that the Pre Checks Action currently is failing due to the package versions. i've currently used a .beta version for the packages to be able to publish them to nuget. befor merging i will create a mayor version of all of them (1.0.0)

@Phil91
Copy link
Member Author

Phil91 commented Jan 23, 2024

@Phil91 Phil91 changed the base branch from dev to release/v1.8.0-RC4 January 23, 2024 14:52
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch 2 times, most recently from 27418e4 to dc764c3 Compare January 24, 2024 07:45
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just some comments.

Please also provide an information about the nuget packges in the readme on root level, similar to the information for docker images, please link there also the documentation in docs/nuget.

@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch 2 times, most recently from 00b8ab0 to fa99e5f Compare January 25, 2024 10:07
@Phil91 Phil91 requested a review from evegufy January 25, 2024 10:08
@evegufy
Copy link
Contributor

evegufy commented Jan 25, 2024

Looks good! Just some comments.

Please also provide an information about the nuget packges in the readme on root level, similar to the information for docker images, please link there also the documentation in docs/nuget.

Thanks for the changes! I still don't see changes to the readme on root level.

@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from fa99e5f to 221d5ae Compare January 25, 2024 13:24
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from 3c238cc to 950e4af Compare February 2, 2024 15:49
@evegufy evegufy dismissed their stale review February 2, 2024 15:54

dismissing review due to vacation. Looks good so far, I think only pre-checks nuget prechecks still need to run successfully.

@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from 950e4af to e9922ef Compare February 3, 2024 12:55
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch 3 times, most recently from eb6cccc to 96c02b7 Compare February 6, 2024 10:03
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from 96c02b7 to acf8d1a Compare February 6, 2024 10:09
@ntruchsess ntruchsess force-pushed the feature/CPLP-3400-framework-nuget branch 5 times, most recently from 7bccd7c to 2d230ad Compare February 6, 2024 12:36
@ntruchsess ntruchsess force-pushed the feature/CPLP-3400-framework-nuget branch from 2d230ad to bdc51d0 Compare February 6, 2024 12:42
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from 8963f7a to 74737f5 Compare February 6, 2024 15:18
@Phil91 Phil91 force-pushed the feature/CPLP-3400-framework-nuget branch from 74737f5 to 3fe14b5 Compare February 6, 2024 15:18
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit a542f14 into eclipse-tractusx:release/v1.8.0-RC5 Feb 6, 2024
8 checks passed
@ntruchsess ntruchsess deleted the feature/CPLP-3400-framework-nuget branch February 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants