Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): upgrade flurl #1053

Merged
merged 2 commits into from
Oct 15, 2024
Merged

build(deps): upgrade flurl #1053

merged 2 commits into from
Oct 15, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Oct 2, 2024

Description

  • upgrade Flurl packages to the latest major
  • remove Newtonsoft.Json references from all non test projects

Why

To upgrade the project dependencies and remove newtonsoft json from non test projects

Issue

Refs: #1052

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91
Copy link
Member Author

Phil91 commented Oct 2, 2024

IP Issues are created

nuget/nuget/-/Flurl.Http.Signed/4.0.2
nuget/nuget/-/Flurl.Signed/4.0.0

@Phil91 Phil91 marked this pull request as ready for review October 2, 2024 09:13
@Phil91 Phil91 added this to the Release 24.12 milestone Oct 2, 2024
ntruchsess
ntruchsess requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ntruchsess ntruchsess left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments. There are also quite a few properties in the models that should be declared as nullable. (As this is not directly related to the flurl-upgrade this might be implemented in a subsequent PR)

src/keycloak/Keycloak.Factory/KeycloakFactory.cs Show resolved Hide resolved
@Phil91 Phil91 requested a review from ntruchsess October 8, 2024 11:58
@Phil91 Phil91 force-pushed the feature/1052-flurl branch 4 times, most recently from 098f973 to 617c897 Compare October 11, 2024 08:59
Phil91 and others added 2 commits October 15, 2024 21:46
@Phil91 @ntruchsess
build(deps): upgrade flurl
67f60c8 
* upgrade Flurl packages to the latest major
* remove Newtonsoft.Json references from all non test projects

Refs: #1052
@ntruchsess
update framework version after rebase + cleanup
2d5f912
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit 44eac5c into main Oct 15, 2024
10 of 11 checks passed
@ntruchsess ntruchsess deleted the feature/1052-flurl branch October 15, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @ntruchsess