Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): update Company validation expression #1043

Merged

Conversation

typecastcloud
Copy link
Contributor

@typecastcloud typecastcloud commented Sep 27, 2024

Description

The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets.

Why

This change ensures that the validation accurately captures company names from different languages and regions.

Issue

Fixes: eclipse-tractusx/portal#360
Refs: eclipse-tractusx/portal-frontend-registration#250

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91
Copy link
Member

Phil91 commented Sep 27, 2024

@typecastcloud please execute ./scripts/update_framework_versions.sh minor on root of the project to update the Nuget Packages

@ntruchsess ntruchsess added this to the Release 24.12 milestone Oct 1, 2024
@ntruchsess
Copy link
Contributor

@MaximilianHauer technically the suggested rexexp looks fine. I verified it does what the comment in the code describes. Please confirm this may be merged (the associated ticket is already in progress with milestone assigned)

@MaximilianHauer
Copy link

@ntruchsess fine for me as we need to provide more international support and BPDM aligned with us that every request will be independently checked on their side and we would not provide any benefit with our restrictions to them.
@typecastcloud please be aware that we currently filter special characters in the wallet api during the wallet creation. if the company name would consist only out of special characters it could cause issues.
@Phil91 and me look into this one already.

Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typecastcloud please rebase on main and resolve the conflict in CHANGELOG.md (please consider to allow commiters to push to your repository or at least the open PR branches - if conflict-resolution is straightforward it's likely we cleanup such conflicts 'on-the-fly' while doing the review)

The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets. This change ensures that the validation accurately captures company names from different languages and regions.

Fixes: eclipse-tractusx/portal#360
Refs: eclipse-tractusx/portal-frontend-registration#250
@typecastcloud typecastcloud force-pushed the feat/allow-all-language-characters branch from 56117ee to 5615e71 Compare October 11, 2024 06:49
@typecastcloud
Copy link
Contributor Author

typecastcloud commented Oct 11, 2024

@typecastcloud please rebase on main and resolve the conflict in CHANGELOG.md (please consider to allow commiters to push to your repository or at least the open PR branches - if conflict-resolution is straightforward it's likely we cleanup such conflicts 'on-the-fly' while doing the review)

Hi @ntruchsess, I always had this on as default and I don't know why this was not possible with this PR. Sorry! I was sick for the last few days.

Rebased and comments are updated.

Copy link

sonarcloud bot commented Oct 11, 2024

@ntruchsess ntruchsess merged commit 5765e4d into eclipse-tractusx:main Oct 14, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

Legal Names | Length Changes and Special Characters | Portal Registration Frontend | Portal Backend
4 participants