Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(technicalUser): add internal external flag to profiles #1038

Merged
merged 2 commits into from
Oct 8, 2024
Merged

feat(technicalUser): add internal external flag to profiles #1038

merged 2 commits into from
Oct 8, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Sep 26, 2024 •
edited
Loading

Description

  • add internal | external flag to the userRoles of an technicalUserProfile

Why

To give the frontend the possibility to show the internal and external roles separately

Issue

Refs: #1007

Corresponding CD PR

eclipse-tractusx/portal#440

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 mentioned this pull request Sep 26, 2024
Merged
4 tasks
@Phil91 Phil91 added this to the Release 24.12 milestone Sep 26, 2024
evegufy
evegufy reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you please resolve the conflict?

@Phil91 Phil91 requested a review from evegufy September 27, 2024 06:40
ntruchsess
ntruchsess previously approved these changes Oct 7, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess linked an issue Oct 7, 2024 that may be closed by this pull request
sig#789 - Enhance the Servicerelease Technical-user-profile API to provide more information #1007
Closed
1 task
@Phil91 Phil91 merged commit 3e3ad98 into main Oct 8, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/1007-userProfile branch October 8, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees
No one assigned
Labels
None yet
Projects
Portal
Status: USER READY
Milestone
Release 24.12
Development

Successfully merging this pull request may close these issues.

sig#789 - Enhance the Servicerelease Technical-user-profile API to provide more information
3 participants
@Phil91 @ntruchsess @evegufy