fix(appManagement): not getting Emails on the Rejection of App Release Request #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Request Ref: 1015
Phil91
previously approved these changes
Sep 19, 2024
|
The error has been introduced when mail-creation was refactored to send the emails asynchronously via process. Another occurrence of calls to RoleBaseSendEmail is also affected. I'll add the required fix to this PR |
ntruchsess
approved these changes
Sep 20, 2024
|
Phil91
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
App Manager is not receiving the email notification upon approval or rejecting the app.
Why
In the App Request Management section, users are not receiving email notifications when an App Release Request is approved or rejected. This error has been introduced with the refactoring of email-creation by process-worker. The dbcontext now must be saved after creating the email-processes. Before the refactoring email-creating did not involve the database.
Issue
Ref: 1015
Checklist