Skip to content

Commit

Permalink
bugfix (unittests): remove asserts depending on db's timing of execut…
Browse files Browse the repository at this point in the history
…ion. (#249)
  • Loading branch information
ntruchsess authored Sep 4, 2023
1 parent 57e69f6 commit 913a6ab
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public async Task SaveChangedAuditableEntity_SetsLastEditorId()
var auditEntries = await sut.AuditCompanyApplication20230214.Where(x => x.Id == ca.Id).ToListAsync();
auditEntries.Should().HaveCount(2).And.Satisfy(
x => x.ApplicationStatusId == CompanyApplicationStatusId.CONFIRMED && x.AuditV1OperationId == AuditOperationId.INSERT,
x => x.ApplicationStatusId == CompanyApplicationStatusId.SELECT_COMPANY_ROLE && x.AuditV1OperationId == AuditOperationId.UPDATE && (x.AuditV1DateLastChanged - now) < TimeSpan.FromSeconds(1) && x.LastEditorId == new Guid("ac1cf001-7fbc-1f2f-817f-bce058020001"));
x => x.ApplicationStatusId == CompanyApplicationStatusId.SELECT_COMPANY_ROLE && x.AuditV1OperationId == AuditOperationId.UPDATE && x.LastEditorId == new Guid("ac1cf001-7fbc-1f2f-817f-bce058020001"));
await trans.RollbackAsync().ConfigureAwait(false);
}

Expand All @@ -94,7 +94,7 @@ public async Task SaveCreatedAuditableEntity_SetsLastEditorId()
ca.DateLastChanged.Should().Be(now);
var auditEntries = await sut.AuditCompanyApplication20230214.Where(x => x.Id == id).ToListAsync();
auditEntries.Should().ContainSingle().Which.Should().Match<AuditCompanyApplication20230214>(
x => x.ApplicationStatusId == CompanyApplicationStatusId.CREATED && (x.DateCreated - before) < TimeSpan.FromSeconds(1) && x.AuditV1OperationId == AuditOperationId.INSERT && (x.AuditV1DateLastChanged - now) < TimeSpan.FromSeconds(1) && x.LastEditorId == new Guid("ac1cf001-7fbc-1f2f-817f-bce058020001"));
x => x.ApplicationStatusId == CompanyApplicationStatusId.CREATED && (x.DateCreated - before) < TimeSpan.FromSeconds(1) && x.AuditV1OperationId == AuditOperationId.INSERT && x.LastEditorId == new Guid("ac1cf001-7fbc-1f2f-817f-bce058020001"));
await trans.RollbackAsync().ConfigureAwait(false);
}

Expand Down Expand Up @@ -124,7 +124,7 @@ public async Task SaveDeletedAuditableEntity_SetsLastEditorId()
ca.DateLastChanged.Should().Be(later);
var auditEntries = await sut.AuditCompanyApplication20230214.Where(x => x.Id == id).ToListAsync();
auditEntries.Should().HaveCount(2).And.Satisfy(
x => x.ApplicationStatusId == CompanyApplicationStatusId.CREATED && (x.DateCreated - before) < TimeSpan.FromSeconds(1) && x.AuditV1OperationId == AuditOperationId.INSERT && (x.AuditV1DateLastChanged - now) < TimeSpan.FromSeconds(1) && x.LastEditorId == new Guid("ac1cf001-7fbc-1f2f-817f-bce058020001"),
x => x.ApplicationStatusId == CompanyApplicationStatusId.CREATED && (x.DateCreated - before) < TimeSpan.FromSeconds(1) && x.AuditV1OperationId == AuditOperationId.INSERT && x.LastEditorId == new Guid("ac1cf001-7fbc-1f2f-817f-bce058020001"),
x => x.ApplicationStatusId == CompanyApplicationStatusId.CREATED && (x.DateCreated - before) < TimeSpan.FromSeconds(1) && x.AuditV1OperationId == AuditOperationId.DELETE && (x.AuditV1DateLastChanged - later) < TimeSpan.FromSeconds(1) && x.LastEditorId == new Guid("ac1cf001-7fbc-1f2f-817f-bce058020001"));
await trans.RollbackAsync().ConfigureAwait(false);
}
Expand Down

0 comments on commit 913a6ab

Please sign in to comment.