Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add stable env configuration file #217

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ds-asmierzchalski
Copy link

@ds-asmierzchalski ds-asmierzchalski commented Oct 14, 2024

Description

A new values.yaml for the stable configuration was added similar to values-int.yaml.

Why

With the new stable environment a specific values.yaml is necessary for the deployment of the service.

Issue

Relates to eclipse-tractusx/portal#408

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@MaximilianHauer
Copy link

@ds-asmierzchalski can you please add some info ?

@ds-asmierzchalski
Copy link
Author

Hi @MaximilianHauer I updated the description. Sorry for the inconvenience.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to direct the PR towards main directly not https://github.com/eclipse-tractusx/policy-hub/tree/feature/add-stable-config as that branch is essentially just a couple commits behind main and not checked out from the 1.1.0 version tag, if that was the assumption.

@@ -0,0 +1,38 @@
###############################################################
# Copyright (c) 2023 Contributors to the Eclipse Foundation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to current year, as the file was just created

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the year was updated

@@ -0,0 +1,62 @@
###############################################################
# Copyright (c) 2023 Contributors to the Eclipse Foundation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to current year, as the file was just created

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the year was updated

@ds-asmierzchalski ds-asmierzchalski changed the base branch from feature/add-stable-config to main October 16, 2024 13:17
@ds-asmierzchalski
Copy link
Author

Updated the pull request to go against main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

3 participants