Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm-chart): use templates for unique resource names #14

Merged
merged 2 commits into from
Jan 23, 2024
Merged

feat(helm-chart): use templates for unique resource names #14

merged 2 commits into from
Jan 23, 2024

Conversation

evegufy
Copy link
Contributor

@evegufy evegufy commented Jan 22, 2024

Description

  • use templates for unique resource names
  • fix wrong service name in ingress

Why

improve helm chart

Issue

follow up to #11

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@evegufy evegufy requested a review from Phil91 January 22, 2024 19:06
@evegufy evegufy merged commit d412b38 into dev Jan 23, 2024
8 checks passed
@evegufy evegufy deleted the feat/helm-unique-resources-with-templates branch January 23, 2024 13:24
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Merged
@evegufy evegufy mentioned this pull request Feb 13, 2024
Closed
This was referenced Feb 15, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil91 Phil91 Phil91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evegufy @Phil91