Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(net8): upgrade to .net8 #102

Merged
merged 1 commit into from
Apr 4, 2024
Merged

feat(net8): upgrade to .net8 #102

merged 1 commit into from
Apr 4, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Apr 4, 2024

Description

  • upgrade nuget packages
  • remove configureAwait from unit tests

Why

Since .NET 7 is only supported until May 14, 2024 the portal services and jobs are upgraded to .NET 8 which is an LTS version

Issue

Refs: #19

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested a review from ntruchsess April 4, 2024 08:28
@Phil91 Phil91 force-pushed the feature/19-net8-upgrade branch 3 times, most recently from 8ad3155 to c853bd5 Compare April 4, 2024 09:14
@Phil91 Phil91 requested a review from evegufy April 4, 2024 11:13
@Phil91
feat(net8): upgrade to .net8
3582acd 
upgrade nuget packages
* remove configureAwait from unit tests

Refs: #19
@Phil91 Phil91 requested a review from ntruchsess April 4, 2024 12:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
5 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 merged commit fb9e3c9 into dev Apr 4, 2024
10 checks passed
@Phil91 Phil91 deleted the feature/19-net8-upgrade branch April 4, 2024 13:13
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@evegufy evegufy Awaiting requested review from evegufy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @ntruchsess