Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs|fix|chore(provisioning-agent): SAST Flaws and CHANGELOG #31

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Aug 29, 2023

WHAT

Addressed four issues from SAST (2XSLT External Entity Disablement, 2Discrepancy between unclean maven deps and clean docker runtime)
Already reference upcoming release in CHANGELOG
Include a cloud-based postgres test which reflects a valid deployment scenario (and its current pitfalls).

WHY

CHANGELOG should reflect release status (TRG)
Render SAST analysis green and close to 100%
include test settings from E2E tests.

FURTHER NOTES

@drcgjung drcgjung marked this pull request as ready for review August 29, 2023 08:22
Copy link
Member

@scherersebastian scherersebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your docker file provisioning/src/main/docker/Dockerfile you change the permission to 755. I think just the ontop user needs executable permission. Maybe chmod 700 is sufficient enough.

@scherersebastian
Copy link
Member

scherersebastian commented Aug 30, 2023

I also added some security docs to your XMLProvider class - makes it easier to understand.
Stylesheet and DTD checks look good :)
Veracode config looks good, too.

@scherersebastian
Copy link
Member

For extra points - you could validate the XML to a schema. This is the best way to prevent XML injection attacks.
No pressure :)

@drcgjung
Copy link
Contributor Author

For extra points - you could validate the XML to a schema. This is the best way to prevent XML injection attacks. No pressure :)

Good point:

#32

@SebastianBezold SebastianBezold merged commit 603ec03 into eclipse-tractusx:main Aug 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants