Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:cxar-919 quality gates #21

Merged

Conversation

drcgjung
Copy link
Contributor

@drcgjung drcgjung commented Aug 22, 2023

WHAT

  • Debugged the build workflow (wrong foldernames)
  • follow release guidelines including chart testing

WHY

  • Initial contribution still had TRG violations.
  • Actions could not be really tested on catenax-ng fork.

FURTHER NOTES

  • The final release branch/workflows (v1.9.5) still need to be setup as main stays on -SNAPSHOT

Largely Closes #5
Closes #20
Closes #19
Merge Hopefully Closes #18

@drcgjung
Copy link
Contributor Author

drcgjung commented Aug 22, 2023

@SebastianBezold I really appreciate your help, still struggling a little bit with the chart testing workflow.

"A bit" was tremendously underestimated. Now the lint workflow also builds the docker images, pushes them to the local registry and tests them in the local cluster.

Release mechanism would be as follows:

  • Maven/Docker is deployed/published/pushed after push to main or vx.x.x tag
  • Helm is released after push to main or release branch

The difference is caused in maven repo typically not allowing to simply "update" existing artifacts (unless they are SNAPSHOTS from main)

@SebastianBezold
Copy link
Contributor

Hi @drcgjung, now worries, we will get that to work :)
Unrelated to that issue, I would kindly ask you to not include the Jira links in your commit messages all the time. Reason:

  • This is a closed system, that not everyone in the open-source community has access to
  • Information will be lost, as soon as consortium phase is over
  • The Link at the beginning of the commit message makes it hard to even see the actual useful info after the link

In best case, the Info, that you are linking to is either included in the PR description itself, or a related GitHub issue.

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @drcgjung could you have a look at the comments regarding the additional info for your used Docker base images and decide, if you want to include it in this PR, or open issues for future addition?

provisioning/README.md Outdated Show resolved Hide resolved

Used base image

[tomcat:9-jre11-temurin](https://hub.docker.com/_/tomcat/tags?page=1&name=9-jre11-temurin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for ontop/ontop we need to provide more info about where to find the original source and so on

@SebastianBezold
Copy link
Contributor

Thanks for the base image info @drcgjung 👍

@SebastianBezold SebastianBezold merged commit d5d2149 into eclipse-tractusx:main Aug 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants