Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve local setup #106

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

anfern777
Copy link

@anfern777 anfern777 commented Jul 3, 2024

Description

A script named local-setup.sh has been created to streamline the setup process for backend and frontend environments. The local setup instructions documentation has also been updated to be more organised, concise, and to reflect the addition of this new script.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@anfern777 anfern777 marked this pull request as ready for review July 3, 2024 13:54
@anfern777 anfern777 marked this pull request as draft July 3, 2024 13:55
@anfern777 anfern777 marked this pull request as ready for review July 3, 2024 13:55
@anfern777 anfern777 marked this pull request as draft July 3, 2024 13:55
@anfern777 anfern777 closed this Jul 3, 2024
@anfern777 anfern777 reopened this Jul 3, 2024
@anfern777 anfern777 changed the title Chore/improve local setup chore: improve local setup Jul 3, 2024
carslen
carslen previously requested changes Jul 3, 2024
Copy link
Contributor

@carslen carslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECA Check failed: https://api.eclipse.org/git/eca/status/gh/eclipse-tractusx/demand-capacity-mgmt/106

If you check the provided checkboxes in the PR description ensure to meet the requirements behind. local-setup.sh is missing required header.

@carslen
Copy link
Contributor

carslen commented Jul 3, 2024

@ClosedSourcerer please add an additional reviewer to review the introduced new code to the repo.

@carslen carslen dismissed their stale review July 5, 2024 07:19

ECA Check ok, missing header added

nitin-vavdiya

This comment was marked as resolved.

@nitin-vavdiya nitin-vavdiya self-requested a review July 5, 2024 10:32
@anfern777 anfern777 marked this pull request as ready for review July 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants