Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ts strict checking for binding mqtt #1053

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

egekorkan
Copy link
Member

I had started on this but did not manage to move forward due to time constraints. I still wanted to make it public so that others can take the work.

@hasanheroglu maybe you can have a quick look? Otherwise, I will try to get back to it in two weeks :)

@egekorkan egekorkan added the binding-mqtt Issues related to mqtt protocol binding label Aug 8, 2023
@relu91 relu91 marked this pull request as ready for review August 11, 2023 12:39
@relu91 relu91 changed the base branch from master to data-generator August 11, 2023 12:40
@relu91 relu91 changed the base branch from data-generator to master August 11, 2023 12:40
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1053 (28c0815) into master (597f34d) will decrease coverage by 0.17%.
Report is 15 commits behind head on master.
The diff coverage is 52.32%.

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   75.54%   75.38%   -0.17%     
==========================================
  Files          80       80              
  Lines       15341    15443     +102     
  Branches     1460     1477      +17     
==========================================
+ Hits        11590    11641      +51     
- Misses       3717     3766      +49     
- Partials       34       36       +2     
Files Changed Coverage Δ
packages/binding-mqtt/src/mqtt-client.ts 74.14% <40.00%> (-5.43%) ⬇️
packages/binding-mqtt/src/mqtt-broker-server.ts 74.78% <56.66%> (-2.24%) ⬇️
packages/binding-mqtt/src/mqtt.ts 94.20% <100.00%> (ø)

... and 5 files with indirect coverage changes

@relu91
Copy link
Member

relu91 commented Aug 11, 2023

@danielpeintner should be ready to go. I think in this case we can squash and merge.

@relu91 relu91 merged commit 0e6e117 into eclipse-thingweb:master Aug 11, 2023
5 of 7 checks passed
@relu91
Copy link
Member

relu91 commented Aug 11, 2023

argh I forgot to squash :/

@egekorkan
Copy link
Member Author

Thanks for doing it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-mqtt Issues related to mqtt protocol binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants