chore(ci): re-enable Node 20 (#1056)

* chore(ci): re-enable Node 20 * chore(ci): use at least Node 16 for all checks * chore(binding-mbus): upgrade node-mbus * docs(README): remove reference to issue #1004 --------- Co-authored-by: reluc <[email protected]>
eclipse-thingweb · Aug 11, 2023 · e0e3fc4 · e0e3fc4
1 parent daa8453
commit e0e3fc4
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 34 deletions.
diff --git a/.github/workflows/ci-full.yaml b/.github/workflows/ci-full.yaml
@@ -8,7 +8,7 @@ jobs:
         strategy:
             matrix:
                 os: [macos-latest, ubuntu-latest, windows-latest]
-                node-version: [16.x, 18.x]
+                node-version: [16.x, 18.x, 20.x]
 
         steps:
             - name: Checkout
@@ -19,9 +19,6 @@ jobs:
               with:
                   node-version: ${{ matrix.node-version }}
                   cache: "npm"
-            - name: npm 7
-              # npm workspaces requires npm v7 or higher
-              run: npm i -g npm@7 --registry=https://registry.npmjs.org
             - name: Install
               run: npm ci
 
@@ -41,14 +38,10 @@ jobs:
             - name: Checkout
               uses: actions/checkout@v2
 
-            - name: Use Node.js 14
+            - name: Use Node.js 16
               uses: actions/setup-node@v1
               with:
-                  node-version: 14
-
-            - name: npm 7
-              # npm workspaces requires npm v7 or higher
-              run: npm i -g npm@7 --registry=https://registry.npmjs.org
+                  node-version: 16
 
             - name: Install
               run: npm ci
@@ -61,10 +54,10 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v1
-            - name: install node v14
+            - name: install node v16
               uses: actions/setup-node@v1
               with:
-                  node-version: 14
+                  node-version: 16
             - name: verify packages version consistency accross sub-modules
               run: npm run check:versions
 

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -8,7 +8,7 @@ jobs:
         strategy:
             matrix:
                 os: [ubuntu-latest]
-                node-version: [16.x, 18.x]
+                node-version: [16.x, 18.x, 20.x]
 
         steps:
             - name: Checkout
@@ -19,9 +19,6 @@ jobs:
               with:
                   node-version: ${{ matrix.node-version }}
                   cache: "npm"
-            - name: npm 7
-              # npm workspaces requires npm v7 or higher
-              run: npm i -g npm@7 --registry=https://registry.npmjs.org
             - name: Install
               run: npm ci
 
@@ -41,14 +38,10 @@ jobs:
             - name: Checkout
               uses: actions/checkout@v2
 
-            - name: Use Node.js 14
+            - name: Use Node.js 16
               uses: actions/setup-node@v1
               with:
-                  node-version: 14
-
-            - name: npm 7
-              # npm workspaces requires npm v7 or higher
-              run: npm i -g npm@7 --registry=https://registry.npmjs.org
+                  node-version: 16
 
             - name: Install
               run: npm ci
@@ -61,10 +54,10 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v1
-            - name: install node v14
+            - name: install node v16
               uses: actions/setup-node@v1
               with:
-                  node-version: 14
+                  node-version: 16
             - name: verify packages version consistency accross sub-modules
               run: npm run check:versions
 

diff --git a/README.md b/README.md
@@ -100,7 +100,6 @@ cs.addCodec(new MyCodec("application/myType"));
 ### To use with Node.js
 
 > **Warning**: We no longer actively support Node.js version 14 and lower.
-> Node.js version 20 is not yet supported (https://github.com/eclipse-thingweb/node-wot/issues/1004)
 
 -   [Node.js](https://nodejs.org/) version 14+
 -   [npm](https://www.npmjs.com/) version 7+

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/binding-mbus/package.json b/packages/binding-mbus/package.json
@@ -39,7 +39,7 @@
     "dependencies": {
         "@node-wot/core": "0.8.8",
         "@node-wot/td-tools": "0.8.8",
-        "node-mbus": "^1.2.2",
+        "node-mbus": "^2.1.0",
         "wot-typescript-definitions": "0.8.0-SNAPSHOT.26"
     },
     "scripts": {