Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: simplify credentials callback usage #80

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Dec 11, 2023

This PR simplifies the handling of credentials provided to clients by replacing the central ClientSecurityProvider class with individual callbacks per ProtocolClientFactory. This should make the handling of credentials more flexible and improve the extensibility with new protocols of the library in the future.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (f3e39bf) 52.28% compared to head (5caeedf) 52.33%.

Files Patch % Lines
lib/src/binding_coap/coap_client.dart 14.28% 6 Missing ⚠️
lib/src/binding_mqtt/mqtt_client_factory.dart 0.00% 5 Missing ⚠️
lib/src/binding_http/http_client_factory.dart 0.00% 4 Missing ⚠️
lib/src/binding_http/http_client.dart 0.00% 3 Missing ⚠️
lib/src/binding_mqtt/mqtt_client.dart 0.00% 3 Missing ⚠️
lib/src/binding_coap/coap_client_factory.dart 71.42% 2 Missing ⚠️
lib/src/core/servient.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   52.28%   52.33%   +0.04%     
==========================================
  Files          70       69       -1     
  Lines        2184     2188       +4     
==========================================
+ Hits         1142     1145       +3     
- Misses       1042     1043       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb force-pushed the security-provider branch 2 times, most recently from ef1571e to f15e450 Compare December 19, 2023 07:33
@JKRhb JKRhb marked this pull request as ready for review December 19, 2023 07:57
@JKRhb JKRhb merged commit d027ca8 into main Dec 19, 2023
4 checks passed
@JKRhb JKRhb deleted the security-provider branch December 19, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants