Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active notebook editor staying active as long as the editor is active #14419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonah-iden
Copy link
Contributor

@jonah-iden jonah-iden commented Nov 8, 2024

What it does

This fixes the activeTextEditor should stay as the active cell as long as the associated notebook editor is also active.
This is important for extensions with a chat window that want to access the current selected code while the chat input is active

How to test

You can find a test extension including vsix here

You can use the Notebook-Test: get current selection to print out the current notebook selection or use the output channel to see the change events.

Even when for example selecting the workspace search or debug side panels, the selection inside the cell should still be available in the extension.

Follow-ups

Review checklist

Reminder for reviewers

@jonah-iden jonah-iden changed the title Fix active notebook editor staying active as long as the editor is ac… Fix active notebook editor staying active as long as the editor is active Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

1 participant