Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor preference localizations #14018

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix editor preference localizations #14018

wants to merge 1 commit into from

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 6, 2024

What it does

While working on something unrelated, I've noticed that the localization eslint checks where turned off for the editor preferences. This turns them back on and fixes the localization issues.

How to test

  1. Install and activate a non-english language pack.
  2. Assert that the values are correctly localized.

Review checklist

Reminder for reviewers

@msujew msujew added preferences issues related to preferences editor issues related to the editor localization issues related to localization/internalization/nls labels Aug 6, 2024
@msujew msujew force-pushed the msujew/fix-editor-preference-localizations branch from 4039e95 to a4d1388 Compare August 6, 2024 13:03
@msujew msujew requested a review from tsmaeder October 10, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmaeder tsmaeder tsmaeder approved these changes

Assignees
No one assigned
Labels
editor issues related to the editor localization issues related to localization/internalization/nls preferences issues related to preferences
Projects
PR Backlog
Status: Needs merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msujew @tsmaeder