Skip to content

Commit

Permalink
fix: set display: block on plugin icon pseudo-element (#13096)
Browse files Browse the repository at this point in the history
Fix the icon pseudo-element being displayed as `inline` by default.
This meant that the `width` and `height` properties were being ignored
and the icons displayed with 0 width.

Also fix css syntax for `width` and `height` properties.

Signed-off-by: Beniamino Ventura <[email protected]>
  • Loading branch information
bvenreply committed Nov 26, 2023
1 parent 6004188 commit 2f4addb
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions packages/plugin-ext/src/main/browser/plugin-shared-style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ export class PluginSharedStyle {
toDispose.push(this.insertRule('.' + iconClass + '::before', theme => `
content: "";
background-position: 2px;
width: ${size}'px';
height: ${size}'px';
display: block;
width: ${size}px;
height: ${size}px;
background: center no-repeat url("${theme.type === 'light' ? lightIconUrl : darkIconUrl}");
background-size: ${size}px;
`));
Expand Down

0 comments on commit 2f4addb

Please sign in to comment.