-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 0.12.0 Release #369
Conversation
jfaltermeier
commented
Oct 30, 2024
•
edited
Loading
edited
- move devcontainer to gke directory
- create changelog
- update versions
- update vsix
7592d4f
to
05dfd71
Compare
CHANGELOG.md
Outdated
|
||
### Breaking Changes in 0.12.0 | ||
|
||
See the helm chart Changelog for [more details](). # TODO UPDATE BEFORE MERGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO after merging helm PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just two minor nitpicks and the TODO in the Changelog
@@ -7,7 +7,7 @@ | |||
|
|||
<groupId>com.example</groupId> | |||
<artifactId>demo</artifactId> | |||
<version>1.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just change the examples pom.xml versions to 0.0.1
in order to avoid updating these everytime we update the real versions? We can also set this to the same version as the rest, but i would make it clear, if this needs to be changed or not. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
@@ -7,7 +7,7 @@ | |||
|
|||
<groupId>com.example</groupId> | |||
<artifactId>demo</artifactId> | |||
<version>1.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
05dfd71
to
90c0dca
Compare
* move devcontainer to gke directory * create changelog * update versions * update vsix
90c0dca
to
67aef14
Compare
Thanks, I updated the version and the TODO (link will properly work after merging the helm chart, but this happens at the end in our process) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍