Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.12.0 Release #369

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Prepare 0.12.0 Release #369

merged 1 commit into from
Oct 30, 2024

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Oct 30, 2024

  • move devcontainer to gke directory
  • create changelog
  • update versions
  • update vsix

@jfaltermeier jfaltermeier force-pushed the release-prep branch 2 times, most recently from 7592d4f to 05dfd71 Compare October 30, 2024 10:41
@jfaltermeier jfaltermeier marked this pull request as ready for review October 30, 2024 10:45
CHANGELOG.md Outdated

### Breaking Changes in 0.12.0

See the helm chart Changelog for [more details](). # TODO UPDATE BEFORE MERGE
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO after merging helm PR

Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor nitpicks and the TODO in the Changelog

@@ -7,7 +7,7 @@

<groupId>com.example</groupId>
<artifactId>demo</artifactId>
<version>1.0-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just change the examples pom.xml versions to 0.0.1 in order to avoid updating these everytime we update the real versions? We can also set this to the same version as the rest, but i would make it clear, if this needs to be changed or not. WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@@ -7,7 +7,7 @@

<groupId>com.example</groupId>
<artifactId>demo</artifactId>
<version>1.0-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

* move devcontainer to gke directory
* create changelog
* update versions
* update vsix
@jfaltermeier
Copy link
Contributor Author

LGTM, just two minor nitpicks and the TODO in the Changelog

Thanks, I updated the version and the TODO (link will properly work after merging the helm chart, but this happens at the end in our process)

Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jfaltermeier jfaltermeier merged commit c356223 into main Oct 30, 2024
21 checks passed
@jfaltermeier jfaltermeier deleted the release-prep branch October 30, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants