Added JDT Java compiler entry for removed Java 7 support in ecj #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trancexpress
force-pushed
the
ecj-java-7-dropped-support
branch
from
928f433
to
72e0b27
Compare
|
See screenshot here: #211 (comment) |
merks
reviewed
Aug 26, 2024
merks
reviewed
Aug 26, 2024
|
Sorry, I seem to have created more noise than necessary. 😢 |
trancexpress
force-pushed
the
ecj-java-7-dropped-support
branch
from
72e0b27
to
bf7fc88
Compare
|
@iloveeclipse it would be good if you can take a look, or suggest someone from JDT who should take a look. I'm not sure if there is enough information in the N&N entry or if the wording is sufficient, to make the change clear to users. |
merks
approved these changes
Aug 26, 2024
|
Please also add a note that this applies also for the IDE, not only compiler. Thanks. I'm on the road today, so can't guarantee I can review anything. |
Added an entry for JDT, mentioning the removal of source, target and release Java 7 and below. See the respective JDT issue: eclipse-jdt/eclipse.jdt.core#2536 Signed-off-by: Simeon Andreev <[email protected]>
trancexpress
force-pushed
the
ecj-java-7-dropped-support
branch
from
bf7fc88
to
383e84a
Compare
|
OK, I think we can merge this then. @merks would you merge this? |
merks
reviewed
Aug 26, 2024
| <td class="title"><a href="#removed-support-for-java7-and-below">Removed support for souce, target and release Java 7 and below</a></td> | ||
| <td class="content"> | ||
| <!-- https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/1367 --> | ||
| <p>The following compiler options are now supported only for Java 8 and above: |
There was a problem hiding this comment.
This <p> is unclosed and should be closed here.
merks
added a commit
to merks/www.eclipse.org-eclipse
that referenced
this pull request
Aug 26, 2024
Merged
merks
added a commit
that referenced
this pull request
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an entry for JDT, mentioning the removal of
--source,--targetand--releaseJava 7 and below.See the respective JDT issue:
eclipse-jdt/eclipse.jdt.core#2536